search

go-graphite / graphite-clickhouse

Graphite cluster backend with ClickHouse support
MIT License
213 stars 52 forks source link

Upgrade prometheus #99

Open Felixoid opened 4 years ago

Felixoid commented 4 years ago

Here's a branch with the updated vendor path https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus

ihard commented 3 years ago

Hi, how working is the branch? I would like to update since there is an assumption that some promql queries do not work because of this.

Felixoid commented 3 years ago

Hey. I have zero experience in Prom, so can't provide any support on the topic. I am not sure why has removed help wanted, since help is definitely needed here

Felixoid commented 3 years ago

I upgraded the branch https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus and there some initial attempts to adjust the code to the latest prom. But since I am not in the context of Prometheus, I am not sure what should be next.

As far as I see, the current prometheus.Querier must be split into two different types, Querier and ChunkQuerier. If one would take care of it, I'll for sure spend time to review it

bzed commented 3 years ago

As you can connect a normal prometheus as remote reader - I'm wondering if its needed to have a prometheus integrated. Providing the remote storage endpoint and running a prometheus instance should be enough? or am I missing something?

Felixoid commented 3 years ago

GCH has a feature to provide graphite metrics in the native prometheus format. See https://github.com/lomik/graphite-clickhouse/blob/master/prometheus/querier_select.go#L33, for example

bzed commented 3 years ago

Ah sorry, I've missed that / is being routed into prometheus. I thought that the remote read/write interface was different code.

bzed commented 1 year ago

@lomik you've updated prometheus with 5955725, any plans to implement the ChunkQuerier also? Otherwise a collegue will have a look into that.