search

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools
https://go-hep.org
BSD 3-Clause "New" or "Revised" License
230 stars 35 forks source link

groot/internal/httpio: first import #919

Closed sbinet closed 2 years ago

sbinet commented 2 years ago

old: reading remote file after having downloaded to a local one new: reading remote file w/ httpio + sync.Pool

  name                    old time/op    new time/op    delta
  DumpHTTP/delay-0s-8        279ms ± 1%     287ms ± 2%   +3.09%  (p=0.000 n=27+29)
  DumpHTTP/delay-5ms-8       279ms ± 2%     288ms ± 2%   +3.06%  (p=0.000 n=29+29)
  DumpHTTP/delay-10ms-8      281ms ± 3%     287ms ± 1%   +2.24%  (p=0.000 n=26+30)
  DumpHTTP/delay-100ms-8     286ms ± 3%     288ms ± 1%   +0.45%  (p=0.032 n=25+29)

  name                    old alloc/op   new alloc/op   delta
  DumpHTTP/delay-0s-8        156MB ± 0%     159MB ± 0%   +1.93%  (p=0.000 n=29+30)
  DumpHTTP/delay-5ms-8       156MB ± 0%     159MB ± 0%   +1.95%  (p=0.000 n=30+30)
  DumpHTTP/delay-10ms-8      155MB ± 0%     159MB ± 0%   +1.95%  (p=0.000 n=30+30)
  DumpHTTP/delay-100ms-8     155MB ± 0%     159MB ± 0%   +1.99%  (p=0.000 n=30+28)

  name                    old allocs/op  new allocs/op  delta
  DumpHTTP/delay-0s-8        81.4k ± 0%    117.6k ± 0%  +44.46%  (p=0.000 n=30+30)
  DumpHTTP/delay-5ms-8       81.4k ± 0%    117.6k ± 0%  +44.48%  (p=0.000 n=30+30)
  DumpHTTP/delay-10ms-8      81.4k ± 0%    117.5k ± 0%  +44.48%  (p=0.000 n=29+30)
  DumpHTTP/delay-100ms-8     81.4k ± 0%    117.6k ± 0%  +44.51%  (p=0.000 n=30+29)

Fixes go-hep#142.

codecov-commenter commented 2 years ago

Codecov Report

Merging #919 (1f01517) into main (c38575f) will increase coverage by 0.02%. The diff coverage is 93.33%.

:exclamation: Current head 1f01517 differs from pull request most recent head 6e1f08a. Consider uploading reports for the commit 6e1f08a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   73.75%   73.78%   +0.02%     
==========================================
  Files         404      406       +2     
  Lines       48554    48620      +66     
==========================================
+ Hits        35812    35874      +62     
- Misses      10460    10463       +3     
- Partials     2282     2283       +1
Impacted Files Coverage Δ
groot/rcmd/dump.go 74.74% <90.47%> (-0.75%) :arrow_down:
groot/internal/httpio/reader.go 92.85% <92.85%> (ø)
groot/internal/httpio/httpio.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c38575f...6e1f08a. Read the comment docs.