search

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools
https://go-hep.org
BSD 3-Clause "New" or "Revised" License
230 stars 35 forks source link

groot/rcmd: improve Dump tree performances #922

Closed sbinet closed 2 years ago

sbinet commented 2 years ago 
  name    old time/op    new time/op    delta
  Dump-8     5.02s ± 2%     3.84s ± 2%  -23.57%  (p=0.000 n=29+27)

  name    old alloc/op   new alloc/op   delta
  Dump-8    2.50GB ± 0%    2.40GB ± 0%   -3.82%  (p=0.000 n=29+30)

  name    old allocs/op  new allocs/op  delta
  Dump-8     38.8M ± 0%     29.3M ± 0%  -24.69%  (p=0.000 n=30+30)

Supersedes https://github.com/go-hep/hep/pull/921.

codecov-commenter commented 2 years ago

Codecov Report

Merging #922 (c38575f) into main (ca83c45) will increase coverage by 0.00%. The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files         404      404           
  Lines       48534    48554   +20     
=======================================
+ Hits        35794    35812   +18     
- Misses      10459    10460    +1     
- Partials     2281     2282    +1
Impacted Files Coverage Δ
groot/rcmd/dump.go 75.49% <91.66%> (+3.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca83c45...c38575f. Read the comment docs.