search

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools
https://go-hep.org
BSD 3-Clause "New" or "Revised" License
230 stars 35 forks source link

removes unreacheable statement #928

Closed chavacava closed 2 years ago

chavacava commented 2 years ago

log.Fatal already returns exit code 1

found with revive rule unreachable-code

codecov-commenter commented 2 years ago

Codecov Report

Merging #928 (abfe1a4) into main (b02724a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         409      409           
  Lines       48779    48779           
=======================================
  Hits        35986    35986           
  Misses      10510    10510           
  Partials     2283     2283

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b02724a...abfe1a4. Read the comment docs.

sbinet commented 2 years ago

ping?

please send a PR against the go-hep/license repository, adding yourself to the AUTHORS and/or CONTRIBUTORS files, so I can merge this PR in.

thanks again.

sbinet commented 2 years ago

needs https://github.com/go-hep/license/pull/13

sbinet commented 2 years ago

thanks a lot.