Rename package fwk/testdata (Go reserved name)

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools

https://go-hep.org

BSD 3-Clause "New" or "Revised" License

230 stars 35 forks source link

Rename package fwk/testdata (Go reserved name) #941

Closed dolmen closed 2 years ago

dolmen commented 2 years ago

testdata is a special name for the Go toolchain. go help packages says:

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".

Package go-hep.org/x/hep/fwk/testdata should be renamed to avoid problems.

dolmen commented 2 years ago

This issue blocks any further changes I would like to propose to the fwk code as files in the fwk/testdata package would be affected.

sbinet commented 2 years ago

yeah, the code under that testdata "fake" package was written before the "internal" concept existed. I guess one could move that code under, say, "fwk/internal/fwktest" or something. WDYT?