search

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools
https://go-hep.org
BSD 3-Clause "New" or "Revised" License
231 stars 35 forks source link

fwk: rename package testdata to internal/fwktest #942

Closed dolmen closed 2 years ago

dolmen commented 2 years ago

Fixes #941 .

1st commit:

$ mkdir -p fwk/internal/fwktest
$ git mv fwk/testdata/*.go fwk/internal/fwktest
$ ( cd fwk/internal/fwktest; sed -i '' 's/package testdata/package fwktest/' *.go )
$ git add fwk/internal/fwktest

2nd commit:

$ ( cd fwk; find . -name '*.go' -exec grep -Hq 'fwk/testdata' '{}' \; -print | xargs sed -i '' -e 's!fwk/testdata!fwk/internal/fwktest!' -e 's!testdata\.!fwktest.!' -e 's!some tools defined in testdata!some tools defined in fwktest!' )
$ git add fwk
sbinet commented 2 years ago

ah. one finnicky import ordering that doesn't suit gofmt (or goimport in this case).

sbinet commented 2 years ago

I'll handle the staticcheck failure.

thanks.