search

go-hep / hep

hep is the mono repository holding all of go-hep.org/x/hep packages and tools
https://go-hep.org
BSD 3-Clause "New" or "Revised" License
230 stars 35 forks source link

brio-gen: cleanup files produced by tests on test success #951

Closed dolmen closed 2 years ago

dolmen commented 2 years ago

In tests of brio-gen, when a failure occurs (generated output changes) the new version is kept on disk. This is the existing behaviour.

With this patch we remove the new version if there is no difference (test success). This allows to automatically remove those temporary files that are useful only for debugging a test failure.

codecov-commenter commented 2 years ago

Codecov Report

Merging #951 (37c2aed) into main (8c3e3fa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         410      410           
  Lines       62067    62067           
=======================================
  Hits        45044    45044           
  Misses      14692    14692           
  Partials     2331     2331

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c3e3fa...37c2aed. Read the comment docs.