go-ini / ini

Package ini provides INI file read and write functionality in Go
https://ini.unknwon.io
Apache License 2.0
3.46k stars 373 forks source link

github.com/smartystreets/goconvey v1.6.4 // indirect #295

Closed zqfan closed 3 years ago

zqfan commented 3 years ago

please remove indirect test dependency from product code

sagikazarmark commented 3 years ago

Unfortunately this is not an indirect dependency, it is actively used throughout the library.

Looking at the dependency tree that goconvey pulls in, it seems to me that both goconvey and its transitive dependencies are abandoned or barely developed at this point which is sad.

I also thing that getting rid of the heavy dependencies would be nice. There are a couple solutions I can think of:

Personally, I think using frameworks like goconvey is an anti-pattern, not only because they are heavy dependencies, but also because Go has an excellent test framework that combined with any assertion library works well.

unknwon commented 3 years ago

I generally agree on what @sagikazarmark has said, and would love fully migrate to testify.

sagikazarmark commented 3 years ago

@unknwon please see the referenced PR.

zqfan commented 3 years ago

Thanks!