gballet commented 5 years ago

When a VM has been terminated, it can not be re-used. By implementing a Restart function that clears the abort flag, clients of the VM interface can re-use a given VM.

codecov-io commented 5 years ago

Codecov Report

Merging #100 into master will increase coverage by 0.01%. The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   66.02%   66.04%   +0.01%     
==========================================
  Files          41       41              
  Lines        4130     4138       +8     
==========================================
+ Hits         2727     2733       +6     
- Misses       1133     1134       +1     
- Partials      270      271       +1

Impacted Files	Coverage Δ
exec/vm.go	`83.87% <86.95%> (-0.27%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1098da...9057da9. Read the comment docs.

sbinet commented 5 years ago

ping?

gballet commented 5 years ago

@sbinet thank you for your feedback. I'm at a conference this week so I will get back to this PR middle of next week. There's a couple extra things that this PR is missing that need some ironing out.

gballet commented 5 years ago

still need to write the tests, then we should be good to go

sbinet commented 5 years ago

ping? (also: could you rebase off the latest master? a lot happened thx to the new work on JIT/AOT...)

gballet commented 5 years ago

@sbinet that should be it, let me know if you have more comments. If not, I'll squash.

go-interpreter / wagon

exec: Add a function to re-use a VM that was Terminated #100

Codecov Report