wasm/leb128: drop ReadXYZSize functions

[codecov-io]

Codecov Report

Merging #107 into master will increase coverage by 0.17%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #107      +/-   ##
=========================================
+ Coverage   68.73%   68.9%   +0.17%     
=========================================
  Files          33      33              
  Lines        3349    3345       -4     
=========================================
+ Hits         2302    2305       +3     
+ Misses        788     783       -5     
+ Partials      259     257       -2

Impacted Files	Coverage Δ
wasm/leb128/read.go	100% <100%> (+16.66%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c018b7...a76146c. Read the comment docs.

[twitchyliquid64]

Note: These are exported functions, so anyone already using it will have their code break. Could we just add a comment to mark them as deprecated instead?

[sbinet]

you're right but:

• wagon isn't v1.0.0 yet so we are "allowed" to break APIs
• going to godoc and listing all importers of leb128 there's only one package that imports leb128 and uses the removed function: an old fork of wagon: https://github.com/netvm/wagon/blob/master/wasm/section.go#L112