go-interpreter / wagon

wagon, a WebAssembly-based Go interpreter, for Go.
BSD 3-Clause "New" or "Revised" License
904 stars 148 forks source link

2/4 - Implement native compilation - Implement boilerplate. #112

Closed twitchyliquid64 closed 5 years ago

twitchyliquid64 commented 5 years ago

Please review the previous PR first - this builds off that.

codecov-io commented 5 years ago

Codecov Report

Merging #112 into master will decrease coverage by 1.1%. The diff coverage is 20.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   68.87%   67.76%   -1.11%     
==========================================
  Files          33       34       +1     
  Lines        3351     3425      +74     
==========================================
+ Hits         2308     2321      +13     
- Misses        785      844      +59     
- Partials      258      260       +2
Impacted Files Coverage Δ
wasm/operators/op.go 75% <0%> (ø) :arrow_up:
exec/func.go 76% <100%> (+0.48%) :arrow_up:
exec/native_compile.go 4% <4%> (ø)
exec/vm.go 82.28% <50%> (-3.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc960d5...d973a5b. Read the comment docs.

twitchyliquid64 commented 5 years ago

:smile: :airplane:

sbinet commented 5 years ago

please rebase on top the latest master. thanks.

twitchyliquid64 commented 5 years ago

Okay, I think I got that to work at the expense of the commit history (I think that can be squashed at merge?), LGTU?