twitchyliquid64 commented 5 years ago

This accidentally builds off an earlier PR, so its dependent on that before it can go in. Have a look at the latest commit to see the changes I intended.

This commit just enables native compilation on windows and OSX. The only platform-specific operation was creating an executable page, and ive confirmed the downstream library we were using (mmap-go) works on those two platforms.

codecov-io commented 5 years ago

Codecov Report

Merging #138 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   69.49%   69.54%   +0.04%     
==========================================
  Files          43       43              
  Lines        4999     5007       +8     
==========================================
+ Hits         3474     3482       +8     
  Misses       1231     1231              
  Partials      294      294

Impacted Files	Coverage Δ
exec/native_compile_nogae.go	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8772f68...49ac63f. Read the comment docs.

sbinet commented 5 years ago

was this rebased off #137? (it seems there are a few redundant changes here...)

(apologies for the belated answer/review: off-the-grid-holidays)

twitchyliquid64 commented 5 years ago

I've merged in upstream/master and that seems to have put it back to normal.

go-interpreter / wagon

Enable use of amd64 backend on Windows & OSX. #138

Codecov Report