search

go-interpreter / wagon

wagon, a WebAssembly-based Go interpreter, for Go.
BSD 3-Clause "New" or "Revised" License
903 stars 148 forks source link

wasm: fix infinite recursion in DuplicateExportError.Error #146

Closed laizy closed 5 years ago

laizy commented 5 years ago

fmt.Sprintf will implicitly call error.Error, causing infinite recursion.

codecov-io commented 5 years ago

Codecov Report

Merging #146 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   69.43%   69.47%   +0.04%     
==========================================
  Files          43       43              
  Lines        4921     4921              
==========================================
+ Hits         3417     3419       +2     
+ Misses       1219     1217       -2     
  Partials      285      285
Impacted Files Coverage Δ
wasm/section.go 53.65% <100%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55a1639...aef1f30. Read the comment docs.