Codecov Report

Merging #158 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   69.54%   69.54%   +<.01%     
==========================================
  Files          43       43              
  Lines        5007     5008       +1     
==========================================
+ Hits         3482     3483       +1     
  Misses       1231     1231              
  Partials      294      294

Impacted Files	Coverage Δ
wast/write.go	`70.15% <100%> (ø)`	:arrow_up:
disasm/disasm.go	`80.76% <100%> (+0.13%)`	:arrow_up:
wasm/section.go	`54.8% <100%> (-0.07%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4176795...6f14816. Read the comment docs.

carltraveler commented 5 years ago

why this commit not merge??

sbinet commented 5 years ago

@carltraveler apologies for the belated answer.

also: deepest apologies if merging the PR #160 before consulting here generated some amount of frustration. in hindsight, I should have brought you into the review process of that #160 PR...

I meant no disrespect. I felt the other PR was clearer to me (but that's probably I am more used to reviewing Twitch's PRs by now.)

again: apologies for this mishap, it does not reflect how I think of your valuable contributions to wagon.

(let me close this PR as I believe PR #160 addressed it. but feel free to reopen and/or rebase if you think some aspects are better handled here.)

go-interpreter / wagon

add validate refer to wasm spec #158

Codecov Report