search

go-interpreter / wagon

wagon, a WebAssembly-based Go interpreter, for Go.
BSD 3-Clause "New" or "Revised" License
903 stars 148 forks source link

wasm: use io.ReadFull instead of Read #189

Closed hajimehoshi closed 4 years ago

hajimehoshi commented 4 years ago

There is no guarantee that io.Read fulfills the given byte slice. ReadByte should use io.ReadFull to ensure that instead.

Fixes #188

codecov-io commented 4 years ago

Codecov Report

Merging #189 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   70.24%   70.24%           
=======================================
  Files          49       49           
  Lines        5499     5499           
=======================================
  Hits         3863     3863           
  Misses       1283     1283           
  Partials      353      353
Impacted Files Coverage Δ
wasm/read.go 73.46% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6163ff...1977033. Read the comment docs.

hajimehoshi commented 4 years ago

https://github.com/go-interpreter/license/pull/20 done :-)