search

go-interpreter / wagon

wagon, a WebAssembly-based Go interpreter, for Go.
BSD 3-Clause "New" or "Revised" License
902 stars 150 forks source link

calculate number of imported funcs #193

Closed zhangzhiqiangcs closed 4 years ago

zhangzhiqiangcs commented 4 years ago

Hi, I read the bug in #190 The problem is that when providing a nil imported object, the len(FunctionIndexSpace) is not equal to the number of imported funcs. So I calculate it. I don't know if we can do it this way. Thanks.

codecov-io commented 4 years ago

Codecov Report

Merging #193 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   69.03%   69.05%   +0.02%     
==========================================
  Files          51       51              
  Lines        5910     5914       +4     
==========================================
+ Hits         4080     4084       +4     
  Misses       1467     1467              
  Partials      363      363
Impacted Files Coverage Δ
wasm/index.go 59.61% <100.00%> (+1.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc6758c...5724631. Read the comment docs.