search

go-irc / irc

A simple go irc library meant to be a building block for other projects
MIT License
142 stars 17 forks source link

Formatting package #79

Open qaisjp opened 4 years ago

qaisjp commented 4 years ago

Hi,

I've got a tiny package here https://github.com/qaisjp/go-discord-irc/tree/master/irc/format which deals with irc text formatting.

The code is essentially ported from the following Node packages:

I'm currently fleshing it out a bit more to abide by the @DanielOaks's IRC formatting living specification and to clean it up a little bit / add tests.

I have not been able to find another package that provides the same functionality, so when I'm done, would you be open to me submitting a pull request to move that content into this repo or under the go-irc org?

p.s. I welcome all feedback on that package / will of course be happy to make any changes required for inclusion in this org.

belak commented 4 years ago

Oh interesting! I've actually been looking for something like this. I'm mid-way through a bit of a re-write (moving Client out to an ircx package for extensions...), so this might work well as a sub-package of that. You can see the status of v4 and ircx in https://github.com/go-irc/irc/issues/78.

qaisjp commented 4 years ago

I've given that issue a little 👍 -- moving the client into ircx sounds great to me!

so this might work well as a sub-package of that

Interesting, so you'd prefer a PR to be sent to ircx instead? I suppose that makes sense, since IRC colors aren't formally part of any IRC specifications.

belak commented 4 years ago

Yep, ircx would be best. Thanks for doing this!