go-jet / jet

Type safe SQL builder with code generation and automatic query result data mapping
Apache License 2.0
2.23k stars 110 forks source link

Feature/daterange #307

Closed sarkan-ag5 closed 4 months ago

sarkan-ag5 commented 5 months ago

This pull request introduces support for PostgreSQL range type fields. With this enhancement, Jet gains the ability to handle PostgreSQL range types seamlessly, enabling users to define and manipulate range-based data directly. The implementation is based on PostgreSQL documents.

go-jet commented 5 months ago

Hi @sarkan-ag5,

Nice work overall.

Couple of additional comments:

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 62.18487% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 90.10%. Comparing base (a9cbf94) to head (893567d).

Files Patch % Lines
generator/template/model_template.go 0.00% 12 Missing :warning:
generator/template/sql_builder_template.go 0.00% 12 Missing :warning:
internal/jet/column_types.go 35.29% 11 Missing :warning:
internal/jet/func_expression.go 82.35% 6 Missing :warning:
internal/jet/literal_expression.go 0.00% 2 Missing :warning:
postgres/expressions.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #307 +/- ## ========================================== - Coverage 90.56% 90.10% -0.46% ========================================== Files 124 126 +2 Lines 7291 7410 +119 ========================================== + Hits 6603 6677 +74 - Misses 528 573 +45 Partials 160 160 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

go-jet commented 4 months ago

Looks, good. The next steps would be to update generator and add integration tests.

go-jet commented 4 months ago

I think we are close now to merge this PR. Could you squash all the commits into one. I'm not completely sure but if I do squash and merge your contribution might be deleted from git history.

go-jet commented 4 months ago

Looks great. :+1: