search

go-jira / jira

simple jira command line client in Go
Apache License 2.0
2.68k stars 328 forks source link

Would you accept a PR to support the password-source: keyring config on Windows? #459

Open bkane-msft opened 2 years ago

bkane-msft commented 2 years ago

When password-source: keyring is set in my config and I run on Windows, I get the following error:

PS C:\Users\bkane> jira login
Keyring is not supported for Windows, see: https://github.com/tmc/keyring

I think this keyring support in Windows can easily be added by replacing https://github.com/tmc/keyring with https://github.com/zalando/go-keyring in the keyringGet/keyringSet code.

Would you accept a PR with this code change and updated docs? jira would be easier to use on Windows and I could share the same config between Windows and Mac :)

georgettica commented 2 years ago

I am not against it and a PR is up to replace the keyring to a newer/more updated version. If you would like to collab/test it that might help your use case aswell