search

go-json-experiment / json

Experimental implementation of a proposed v2 encoding/json package
BSD 3-Clause "New" or "Revised" License
341 stars 11 forks source link

Fix latter to later in options.go #13

Closed lostluck closed 8 months ago

lostluck commented 9 months ago

Tiny grammar nit/typo. Latter isn't entirely wrong, but usually means the 2nd of two choices, rather than the last of many choices. Contextually later is preferred. I think. I'm a software engineer not an editor.

lostluck commented 8 months ago

I'd merge it, but I'm not a committer. Just picking a low hanging fruit while I admire the Options approach being taken here.

dsnet commented 8 months ago

Thanks for the PR! Sorry for the delay. This repo is actually a mirror of a private a repo. We decided to make this the source of truth for the time being now that this prototype is public knowledge. Also, we're going to only accept PRs from individuals who have signed the CLA (since the intent is to eventually merge into the Go project). You're an employee of Google, so I don't think there are any issues.

lostluck commented 8 months ago

I have historically signed the Go CLA at least. It's just on via my @google account, rather than any personal account. https://go-review.googlesource.com/q/owner:rebo@google.com

I don't have separate github accounts at least.