search

go-json-experiment / json

Experimental implementation of a proposed v2 encoding/json package
BSD 3-Clause "New" or "Revised" License
341 stars 11 forks source link

Correct decoder panic message #32

Closed renthraysk closed 2 months ago

renthraysk commented 2 months ago

Decoder panic message refers to io.Writer, should be io.Reader

dsnet commented 2 months ago

Hi, thanks for the PR.

I apologize for being a stickler for legal rules. Since the goal of this is intended to merge into the Go toolchain, we'll need every contribution to have also signed the Go CLA. Is there a merged commit in any of the Go repositories that you can point to that proves you've signed the CLA? Thanks!

renthraysk commented 2 months ago

Yes, last one was into net/http2

https://github.com/golang/net/commit/2e3eb7b945c2d9c792af7388e297d53078fd9e76

dsnet commented 2 months ago

Thank you!