go-json-experiment / json

Experimental implementation of a proposed v2 encoding/json package
BSD 3-Clause "New" or "Revised" License
341 stars 11 forks source link

Allow options `,inline,omitempty` #39

Closed morlay closed 1 month ago

morlay commented 1 month ago

Marshal failed with https://github.com/kubernetes/api/blob/master/networking/v1/types.go#L418

May consider to support this case.

dsnet commented 1 month ago

Hi, I'm not sure I understand what ,inline,omitempty means.

I don't understand what it means for both of these options to be used together.

I argue that Kubernetes should fix the generation of their types to stop an invalid combination of tag options.

morlay commented 1 month ago

@dsnet Sure, it make sence. I just want to confirm the tag options limit here will be landing in json/v2.