search

go-kit / kit

A standard library for microservices.
https://gokit.io
MIT License
26.53k stars 2.43k forks source link

Refactor cmp #1193

Closed sashamelentyev closed 2 years ago

sashamelentyev commented 3 years ago

Data race again... @sagikazarmark, @peterbourgon, please check

sagikazarmark commented 3 years ago

Eureka tests sometimes fail...really, we should just get rid of it already.

peterbourgon commented 3 years ago

@alexander-melentyev What problem does this solve?

peterbourgon commented 3 years ago

I think we should probably just deprecate or remove sd/eureka altogether, it's not really used any more, as far as I know.

sashamelentyev commented 3 years ago

Nothing. Code Is shorter

sashamelentyev commented 3 years ago

@sagikazarmark @peterbourgon I create PR #1194 for remove sd/eureka

sashamelentyev commented 2 years ago

@peterbourgon I close this?

peterbourgon commented 2 years ago

Yeah probably best.