search

go-kit / kit

A standard library for microservices.
https://gokit.io
MIT License
26.5k stars 2.42k forks source link

support for istio distributed tracing #977

Open salanfe opened 4 years ago

salanfe commented 4 years ago

Hi guys,

I've been using go-kit for some times now (high five for the amazing work !) and have been developing micro-services on Kubernetes and istio where istio tracing is leveraged. If interested in supporting istio tracing through simple header propagation (istio doc), I have working code that I would be happy to push through a pull request.

Basically the code implements the function func ServerBefore(before ...RequestFunc) ServerOption for HTTP and gRPC

defined here

so that header values can be saved in the context, and then inject to every downstream requests.

Is it something you see being pushed to your code base ? Let me know. Cheers

basvanbeek commented 4 years ago

Specifically tailored to Istio I think it does not provide a whole lot of value. I do see where one could have a generic "baggage" like header propagation middleware for clients and servers with the ability to specifically whitelist or blacklist which headers to allow or deny for propagation.

By the way if you want to have Go kit interop in distributed tracing you can already do so. Go kit supports Zipkin, OpenTracing and OpenCensus instrumentation thus you can use these to already propagate traces (and even augment traces with local in process spans).

salanfe commented 4 years ago

Hi, thanks for your reply. I understand, makes sense. Today, the trend is to offload middlewares to the service mesh as much as possible : middlewares like

however tracing or accessing custom claims in JWT (for example) still require to propagate requests' headers to downstream services. This is two areas where header propagation has been implemented in our backends. So your suggestion of a generic "baggage" middleware for header propagation makes sense to me.

lewsmith commented 1 year ago

@salanfe, it's been a while, but do you have an example repo showing your usage of ServerBefore/ServerOption for istio header propagation?

intel352 commented 1 year ago

@peterbourgon you noted this as help wanted, what's the expected direction here?