Multi kod.Main implements supported?

[leopku]

My app was a command-line app based on cobra and had many sub commands as different entrances.

• cmd/demo1.go

type demo1Impl struct {
    kod.Implements[kod.Main]
    db kod.Ref[db.Component]
}

...

• cmd/demo2.go

type demo2Impl struct {
    kod.Implements[kod.Main]
    db kod.Ref[db.Component]
}

...

result as

Error: components [github.com/go-kod/kod/Main], error vertex already exists

[sysulq]

I would think about it， thanks for the suguestion

[sysulq]

@leopku I would like to add lazy init feature to support multiple cmd component in one kod.Main，without the need to init unused resources，which would be nice for this situation，what do you think？

[leopku]

@leopku I would like to add lazy init feature to support multiple cmd component in one kod.Main，without the need to init unused resources，which would be nice for this situation，what do you think？

Sounds great. Hoping to test it.

[sysulq]

@leopku I created a pr #169 for this lazy init feature, could you help to test it to check if everything works fine, thanks~

[leopku]

@sysulq I'm testing it now. Feedback will be A.S.A.P.

[leopku]

kod.LazyInit was added to both two demoImpl, but error Error: components [github.com/go-kod/kod/Main], error vertex already exists wasn't changed.

any advice?

[sysulq]

@leopku Do not create two kod.Main, try like this:

type app struct {
  kod.Implemenets[kod.Main]
  cmd1 kod.Ref[Cmd1]
  cmd2 kod.Ref[Cmd2]
}

type cmd1 struct {
  kod.Implemenets[Cmd1]
  kod.LazyInit
}

type cmd2 struct {
  kod.Implemenets[Cmd2]
  kod.LazyInit
}

And you can call cmd1 or cmd2 in each cobra subcommand, without the need to initial another cmd component at the same time.

[leopku]

When I running kod generate -s ./..., I got error as below,

[struct2interface] 1.885103ms
-: # github.com/leopku/kodtest/cmd
cmd/kod_gen_interface.go:10:6: IMigration redeclared in this block
        cmd/demo2.go:15:6: other declaration of IMigration
cmd/demo2.go:41:17: *demo2Impl does not satisfy kod.PointerToMain[demo2Impl] (wrong type for method implements)
                have implements(IMigration)
                want implements(kod.Main)
/Users/leo/Project/go/kodtest/cmd/kod_gen_interface.go:10:6: IMigration redeclared in this block
/Users/leo/Project/go/kodtest/cmd/demo2.go:15:6:        other declaration of IMigration
/Users/leo/Project/go/kodtest/cmd/demo2.go:41:10: *demo2Impl does not satisfy kod.PointerToMain[demo2Impl] (wrong type for method implements)
                have implements(IMigration)
                want implements(kod.Main)

Demo codes was uploaded to https://github.com/leopku/kodtest

[sysulq]

You can give me write permission for this repo, and I would make it through :-)

[leopku]

@sysulq invite sent.

[sysulq]

@leopku done

[leopku]

Thanks a lot. I misunderstood the usage. Interface can be used in kod.Implements without pre-defined, amazing...

[sysulq]

Yep, and you can even run kod generate -s -w ./... to watch the changes, and kod would rerun generate automatically when changes happen :-)

With kod, we don't need to care about how to create/bind these components, so we can focus more on component design and test cases. Enjoy it and hope more feedbacks~

[leopku]

Amazing and issue closed

[leopku]

@sysulq Failed for simple complex case when ref from another package. Details see demo2 in https://github.com/leopku/kodtest

$ kod generate -s ./...
$ go run main.go demo2

result as

Error: component implementation struct cmd.demo2Impl has field kod.Ref[github.com/leopku/kodtest/pkg/migrate.Migrate], but component migrate.Migrate was not registered; maybe you forgot to run 'kod generate'
exit status 1

[sysulq]

@leopku kod.Ref only support interface, instead of struct. You can checkout the latest version.

[leopku]

aah, got it.