search

go-kod / kod

A generics based dependency injection application framework for Go, support OpenTelemetry trace/metric/log natively 🚀🚀🚀
https://pkg.go.dev/github.com/go-kod/kod
Apache License 2.0
109 stars 3 forks source link

golangci config file is missing #174

Closed ccoVeille closed 3 weeks ago

ccoVeille commented 3 weeks ago

The project should have a .golangci.yml or at least Taskfile.yml should use golangci-lint run --no-config

because the way golangci-lint works when looking for configuration files, if there is no golangci file in current project, it will try the parent folders. If there is one it would apply its settings

I do have this locally to be able to test random Go project with a full set of rules. my settings are way more restrictive than the default values.

Originally posted by @ccoVeille in https://github.com/go-kod/kod/issues/149#issuecomment-2180921824

sysulq commented 3 weeks ago

PR is welcome :-)

ccoVeille commented 3 weeks ago

Sure then I will @sysulq, could you assign me the ticket ?

Thanks

ccoVeille commented 3 weeks ago

You inspired me to create

https://github.com/ccoVeille/golangci-lint-config-examples

It's empty now, but you can star and watch