search

go-kod / kod

A generics based dependency injection application framework for Go, support OpenTelemetry trace/metric/log natively 🚀🚀🚀
https://pkg.go.dev/github.com/go-kod/kod
Apache License 2.0
109 stars 3 forks source link

ci: add more golangci lint rules #183

Closed ccoVeille closed 2 weeks ago

ccoVeille commented 2 weeks ago

Fixes #178

ccoVeille commented 2 weeks ago

I let you address the remaining linting issues, mostly bad design or useless arguments in function

Please push to this PR

ccoVeille commented 2 weeks ago

You can have a look here

https://github.com/go-kod/kod/actions/runs/9719259735/job/26828726924?pr=183

@sysulq

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (c1650fc) to head (05427d2). Report is 1 commits behind head on main.

Files Patch % Lines
cmd/kod/internal/generate.go 50.00% 0 Missing and 1 partial :warning:
kod.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ========================================== + Coverage 84.99% 85.02% +0.03% ========================================== Files 41 41 Lines 2132 2137 +5 ========================================== + Hits 1812 1817 +5 Misses 215 215 Partials 105 105 ``` | [Flag](https://app.codecov.io/gh/go-kod/kod/pull/183/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-kod) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/go-kod/kod/pull/183/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-kod) | `85.02% <95.91%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-kod#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ccoVeille commented 1 week ago

Thanks

You helped me to spot a few errors I had in my repository