go-kratos / kratos-layout

Kratos Project Template
http://go-kratos.dev
MIT License
411 stars 212 forks source link

Use ditroless base image rather than debian slim #90

Closed inductor closed 12 months ago

inductor commented 2 years ago

The current base image with debian slim has the following package dependency

https://github.com/go-kratos/kratos-layout/blob/ce6c357221295296cd224502de69bda79c69f438/Dockerfile#L10-L12

It's actually covered by https://gcr.io/distroless/static-debian11 and even lighter than the slim image.

https://github.com/GoogleContainerTools/distroless/blob/main/gcscache/internal/dpkg/info.go

shenqidebaozi commented 2 years ago

Can smaller images provide complete operational support? If yes, can you submit a PR.

117503445 commented 1 year ago

gcr.io/distroless/static-debian11 does not contain the shell. On the one hand this increases security and reduces the size of the image, on the other hand it makes debugging difficult for the user.

My personal preference is to use the distroless image. If this is acceptable to you, I would like to sumbit a PR.

dosubot[bot] commented 1 year ago

Hi, @inductor! I'm Dosu, and I'm helping the kratos-layout team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, the issue suggests using the distroless base image instead of the current debian slim image for the project. There have been two comments on the issue, with one user asking if smaller images can provide complete operational support and requesting a PR, and another expressing a personal preference for the distroless image and offering to submit a PR if acceptable.

It seems that there is a potential resolution to the issue by using the distroless base image. If this issue is still relevant to the latest version of the kratos-layout repository, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days.

Thank you for your contribution to the kratos-layout repository!