search

go-language-server / protocol

Package protocol implements Language Server Protocol specification in Go
https://pkg.go.dev/go.lsp.dev/protocol
BSD 3-Clause "New" or "Revised" License
97 stars 15 forks source link

v0.10.0 compatibility issue with jsonrpc2 v0.9.0 #22

Closed ConnorPickles closed 3 years ago

ConnorPickles commented 3 years ago

At handler_json.go:47, id is cast using int64(id) instead of int32(id), causing an error since jsonrpc2 is expecting int32 at wire.go:60.

Not sure which package is correct. Happy to create a PR to fix this, but didn't want to be presumptuous.

slzatz commented 3 years ago

I've tried to fork the repository and change go.mod to point at the fork until this is fixed but somehow even with go.mod changed, it's still looking for go.lsp.dev/protocol. Anyone with more go experience have any advice?

ConnorPickles commented 3 years ago

@zchee Is this something you have time to quickly fix?

zchee commented 3 years ago

@ConnorPickles @slzatz Sorry for the late reply.

I develop into https://github.com/go-language-server/protocol/pull/21, which supported jsonrpc2 v0.9.0.

I’d testing that PR’s branch internally. It seems no issue to following vscode-languageserver-node upstream change. Will merge above PR and cut new version later. Sorry for confused you.

ConnorPickles commented 3 years ago

Glad to know a fix is coming, saves me from having to fork and host it myself! Thanks for the update.

zchee commented 3 years ago

@slzatz @ConnorPickles merged