search

go-language-server / protocol

Package protocol implements Language Server Protocol specification in Go
https://pkg.go.dev/go.lsp.dev/protocol
BSD 3-Clause "New" or "Revised" License
98 stars 15 forks source link

ProgressParams.Token should be a pointer or it won't marshal. #30

Open perrito666 opened 2 years ago

perrito666 commented 2 years ago

Token type has a custom Marshaller/Unmarshaler and no public attributes. When used in ProgressParams it Marshals to a {} instead of string and, at least VSCode silently ignores it as it cannot find a corresponding type.

I wanted to contribute a patch but I am not sure how this is being generated.

Thank you very much for this library

create-issue-branch[bot] commented 2 years ago

Branch issue-30-ProgressParams_Token_should_be_a_pointer_or_it_won_t_marshal created!

zchee commented 2 years ago

@perrito666 sorry for the delay. will looking it

mnoah1 commented 3 months ago

Hello - I wanted to see if anyone is looking into this? Should we create a PR?