search

go-language-server / protocol

Package protocol implements Language Server Protocol specification in Go
https://pkg.go.dev/go.lsp.dev/protocol
BSD 3-Clause "New" or "Revised" License
98 stars 15 forks source link

general: fix CompletionItemKind to nest valueSet #6

Closed micnncim closed 5 years ago

micnncim commented 5 years ago

Close #2.

zchee commented 5 years ago

ref: https://microsoft.github.io/language-server-protocol/specification#textdocumentclientcapabilities-define-capabilities-the-editor--tool-provides-on-text-documents

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.2%. The diff coverage is 79.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #6     +/-   ##
=======================================
+ Coverage    33.8%    34%   +0.2%     
=======================================
  Files          26     26             
  Lines        4352   4374     +22     
=======================================
+ Hits         1474   1491     +17     
- Misses       2823   2827      +4     
- Partials       55     56      +1
Flag Coverage Δ
#gojay 37.5% <79.1%> (+0.2%) :arrow_up:
#json 3% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
general.go 0% <ø> (ø) :arrow_up:
general_gojay.go 67.9% <79.1%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c61d1d...6d43678. Read the comment docs.