search

go-ldap / ldap

Basic LDAP v3 functionality for the GO programming language.
Other
2.25k stars 355 forks source link

initial cut of context support #406

Open asuffield opened 1 year ago

johnweldon commented 1 year ago

Very nice - thank you.

When you're ready to add the changes to the v3 folder, and you're satisfied it's ready we can make the final approval call.

firefart commented 9 months ago

any update on this? Having a proper context in the package for timeouts and cancellation would be really nice to have

asuffield commented 9 months ago

I'm not able to work on it at present (annoying employer restrictions on open source contributions). Please finish it off and ship it if you can.

firefart commented 9 months ago

I just had a look at the code and I am a bit confused because the same code seems to live in the v3 and in the main directory and past pull requests modify both places. Which one is the correct place to implement the context usage? I guess the root directory is pre v3 and should not be modified?

johnweldon commented 9 months ago

I just had a look at the code and I am a bit confused because the same code seems to live in the v3 and in the main directory and past pull requests modify both places. Which one is the correct place to implement the context usage? I guess the root directory is pre v3 and should not be modified?

You're right to be confused - we started down the path of modifying both places before we (I) fully understood the Go versioning and module scheme - for now we continue to duplicate the changes between the root and v3.

At some point we'll need to clean up the repository, but haven't taken the time yet.