search

go-ldap / ldap

Basic LDAP v3 functionality for the GO programming language.
Other
2.19k stars 352 forks source link

IsErrorAnyOf should match the given result code even if the error is wrapped #471

Closed t2y closed 7 months ago

t2y commented 7 months ago

This might break compatibility, but I guess that most developers want this behavior. What do you think?

t2y commented 7 months ago

CI job failed, but it is another issue instead of this PR.

https://github.com/go-ldap/ldap/actions/runs/6781841980/job/18432888679#step:5:67

t2y commented 7 months ago

--- FAIL: FuzzParseDN (0.00s) --- FAIL: FuzzDecodeEscapedSymbols (0.00s) --- FAIL: FuzzEscapeDN (0.00s) --- FAIL: FuzzParseDN (0.00s) --- FAIL: FuzzDecodeEscapedSymbols (0.00s) --- FAIL: FuzzEscapeDN (0.00s) --- FAIL: FuzzParseDN (0.00s) --- FAIL: FuzzDecodeEscapedSymbols (0.00s) --- FAIL: FuzzEscapeDN (0.00s)

https://github.com/go-ldap/ldap/actions/runs/6781841980/job/18726095280?pr=471

t2y commented 7 months ago

Still, three jobs are left. Could you re-run or permit me to run CI jobs?

t2y commented 7 months ago

I will rebase from #473 if it would be merged first. Then, CI jobs will be passed.

t2y commented 7 months ago

As intended.

johnweldon commented 7 months ago

Thank you again @t2y