search

go-ldap / ldap

Basic LDAP v3 functionality for the GO programming language.
Other
2.19k stars 352 forks source link

feat: Add support for children scope choice const #480

Closed sirzzang closed 5 months ago

sirzzang commented 5 months ago

This PR adds const declaration for representing children scope value 3.

cpuschma commented 5 months ago

Hi, thank you for your PR.

It seems LDAP_SCOPE_SUBORDINATE is an OpenLDAP server extension. May you please add a comment with a reference to OpenLDAP for clarification?

// ScopeChildren is an OpenLDAP extension that may not be supported by another directory server.
// See: https://github.com/openldap/openldap/blob/7c55484ee153047efd0e562fc1638c1a2525f320/include/ldap.h#L598

Also, please mirror your changes to the v3 directory as well. Then we can get this merged

Thank you!