search

go-llvm / llgo

LLVM-based compiler for Go
Other
1.25k stars 81 forks source link

Move to upstream LLVM bindings #219

Closed pcc closed 9 years ago

minux commented 9 years ago

could you please address the partial download first?

right now go get will svn co the entire llvm trunk and take a long time.

Perhaps it needs upstream support for partial checkout but at least the meta flags should point to the bindings/go directory.

pcc commented 9 years ago

The right thing to do by default is to check out the entire tree. Otherwise it will be easy to run into version skew issues. See also the discussion on the LLVM mailing list.

https://groups.google.com/forum/#!topic/llvm-dev/2D6SXgbT26c

People who really want partial checkouts are free to use manual checkouts and the byollvm tag.

axw commented 9 years ago

On Tue, Oct 21, 2014 at 7:59 AM, minux notifications@github.com wrote:

could you please address the partial download first?

right now go get will svn co the entire llvm trunk and take a long time.

I timed it yesterday, it took less than a minute (it was 40-something seconds). Not that bad IMO.

Perhaps it needs upstream support for partial checkout but at least the meta flags should point to the bindings/go directory.

FWIW, you can do this:

$ svn checkout --non-recursive http://llvm.org/svn/llvm-project/llvm/trunk llvm $ mkdir llvm/bindings $ svn update llvm/bindings/go

axw commented 9 years ago

LGTM. Not quite sure about the alwaysrun, but I can see that it'll check the rev in the build script and bail anyway.