search

go-macaron / session

Package session is a middleware that provides the session management of Macaron.
Apache License 2.0
26 stars 27 forks source link

Destory => Destroy? #15

Open lol768 opened 8 years ago

lol768 commented 8 years ago

Destory isn't a word, but I imagine this will break backwards compatibility?

https://github.com/go-macaron/session/blob/master/session.go#L57

unknwon commented 8 years ago

Good point...

mjtrangoni commented 6 years ago

How about fixing this? I know this is exported, but It is always confuse reading Destory for a Destroy action. It could be fixed in a major release.

unknwon commented 6 years ago

@mjtrangoni yes, that's why the issue is still not fixed by no major release is planned anytime soon...

unknwon commented 5 years ago

Using Go Modules and push out a v2 release seems ideal.