align jsdoc with actual parameter name and replace var with let

go-macaroon / js-macaroon

Javascript implementation of macaroons

BSD 3-Clause "New" or "Revised" License

41 stars 22 forks source link

align jsdoc with actual parameter name and replace var with let #23

Closed nitram509 closed 6 years ago

nitram509 commented 6 years ago

I've just changed some JSDOC comments and replaced var with let keyword. These where warnings/recommendations from my IDE. This results in reduced number of warnings from 34 to 3.

Feedback is welcome.

Regards Martin

rogpeppe commented 6 years ago

@nitram509 Out of interest, what are the remaining three warnings?

nitram509 commented 6 years ago

Here the 3 remaining warnings, where I was not patient enough to find a proper solution ;)

Line 22: @param {any} x The object to be converted to string form.
- "any" seems to be not supported as type in JSDOC
Line 821: _exportBinaryV1() {
- method can be static
Line 1141: return;
- return is unnecessary as the last statement in a function with no return value