Closed nickrobison-usds closed 5 years ago
Thanks for the pull request @nickrobison-usds 👍 !
Could you please add an additional test case for this? The best place for it would be in https://github.com/go-macaroon/js-macaroon/blob/master/test/verify.js
You can run the tests locally with npm t
.
Thanks again @nickrobison-usds
When decryption fails due to an incorrect root key, the response from the
decrypt
function is null instead of false, this adds a check to ensure that the error is correctly thrown, otherwise the error comes from the downstream method and is less clear.