search

go-macaroon / js-macaroon

Javascript implementation of macaroons
BSD 3-Clause "New" or "Revised" License
41 stars 22 forks source link

extra param to bytesToString() #49

Open unional opened 4 years ago

unional commented 4 years ago

At https://github.com/go-macaroon/js-macaroon/blob/master/macaroon.js#L1015

Maybe you mean locationStr: bytesToString(v2JSONField(caveat, 'l', false)),?

I'm discover this while I try to add TypeScript definition to this library (actually I think converting to TypeScript is easier).

Are you open to accept PR for the type definition or convert to TypeScript?

fabricematrat commented 4 years ago

Sure that's seems a good idea

hatched commented 4 years ago

I've created an issue to hold the discussion around converting this library to TS: https://github.com/go-macaroon/js-macaroon/issues/53

hatched commented 4 years ago

And good catch with that bug, thanks!

unional commented 4 years ago

And good catch with that bug, thanks!

Thanks TypeScript for that one. ;)