go-macaroon / js-macaroon

Javascript implementation of macaroons
BSD 3-Clause "New" or "Revised" License
41 stars 22 forks source link

feat: add type definitions #50

Open unional opened 4 years ago

unional commented 4 years ago

Adding TypeScript type definitions to the library.

hatched commented 4 years ago

Thanks for this PR!

I just wanted to let you know that I've seen this and will get to it as soon as I can.

In response to your question on #49 We'd definitely be interested in converting this to TS, I've created an issue to hold discussions around this topic https://github.com/go-macaroon/js-macaroon/issues/53

unional commented 4 years ago

I have a TS version in my fork. I'll do some clean up and then file a PR . :)