go-macaroon / js-macaroon

Javascript implementation of macaroons
BSD 3-Clause "New" or "Revised" License
41 stars 22 forks source link

"npm install js-macaroon" fails in fresh project #9

Closed cjwatson closed 7 years ago

cjwatson commented 7 years ago
<cjwatson@niejwein ~/test>$ npm init
This utility will walk you through creating a package.json file.
It only covers the most common items, and tries to guess sensible defaults.

See `npm help json` for definitive documentation on these fields
and exactly what they do.

Use `npm install <pkg> --save` afterwards to install a package and
save it as a dependency in the package.json file.

Press ^C at any time to quit.
name: (x) test
version: (1.0.0)
description:
entry point: (index.js)
test command:
git repository:
keywords:
author:
license: (ISC)
About to write to /home/cjwatson/test/package.json:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC"
}

Is this ok? (yes)
<cjwatson@niejwein ~/test>$ npm install --save js-macaroon
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated node-uuid@1.4.7: use uuid module instead

> js-macaroon@1.0.1 postinstall /home/cjwatson/test/node_modules/js-macaroon
> make build

mkdir -p build
cat templates/yui-header.js \
        node_modules/sjcl/sjcl.js \
        node_modules/tweetnacl/nacl-fast.js \
        macaroon.js \
        templates/yui-footer.js > build/yui-macaroon.js
cat: node_modules/sjcl/sjcl.js: No such file or directory
cat: node_modules/tweetnacl/nacl-fast.js: No such file or directory
Makefile:24: recipe for target 'build' failed
make: *** [build] Error 1
npm WARN test@1.0.0 No description
npm WARN test@1.0.0 No repository field.
npm ERR! Linux 4.4.0-59-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install" "--save" "js-macaroon"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE

npm ERR! js-macaroon@1.0.1 postinstall: `make build`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the js-macaroon@1.0.1 postinstall script 'make build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the js-macaroon package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     make build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs js-macaroon
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls js-macaroon
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/cjwatson/test/npm-debug.log

Installing sjcl and tweetnacl first makes this work, but this sort of thing is a hassle for dependent projects.

rogpeppe commented 7 years ago

Fixed by new version (2.0.0) published to https://www.npmjs.com/package/macaroon and confirmed as fixed by @cjwatson.