search

go-macaroon / macaroon

A native Go implementation of macaroons
BSD 3-Clause "New" or "Revised" License
182 stars 24 forks source link

Use byte slice for caveat IDs #17

Closed titanous closed 7 years ago

titanous commented 8 years ago

Using a byte slice is consistent with the macaroon ID, and allows adding caveats that have been encoded into byte slices without an extra round-trip through a string.

This also removes the valid UTF-8 requirement for V2 macaroons, which use a binary-safe encoding.

Closes #16

rogpeppe commented 7 years ago

Thanks for this PR - it was ahead of its time! Superceded by PR #25.