search

go-mail / mail

Actively maintained fork of gomail. The best way to send emails in Go.
MIT License
464 stars 77 forks source link

Suggest NetDialTimeout be part of Dialer NOT Global #40

Open krolaw opened 5 years ago

krolaw commented 5 years ago

For systems like Google's app engine (standard), out going sockets need a context (per incoming http connection). see: https://godoc.org/google.golang.org/appengine/socket This makes it really hard when the netDialout command is global, since simultaneous requests are coming in. It's much more practical than before though.

ivy commented 5 years ago

@krolaw Agreed. I would accept a pull request adding a NetDialTimeout field to Dialer and using the global NetDialTimeout as a fallback.

Edit: I see you've already done this in PR #41. I'll review and see if we can get this merged. 😄

krolaw commented 5 years ago

Hi, any movement on this? Thanks.