go-music-theory / music-theory

Go models of Note, Scale, Chord and Key
https://gopkg.in/music-theory.v0
GNU General Public License v3.0
432 stars 44 forks source link

Update implementation of command actions #25

Closed raff closed 4 years ago

raff commented 7 years ago

A current build returns the following warning message when run:

DEPRECATED Action signature. Must be cli.ActionFunc. This is an error in the application. Please contact the distributor of this application if this is not you. See https://github.com/urfave/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature

It seems that the definition of Action methods has changed and you now need to return an error: Action: func (c *cli.context) error {}

charneykaye commented 7 years ago

Thanks very much! I'll fix this tomorrow.

charneykaye commented 7 years ago

Apologies for delay. Looks like it's worth updating the whole project slightly, to the latest and greatest Go CLI structure. Working on it..

charneykaye commented 4 years ago

Resolved by #31