search

go-music-theory / music-theory

Go models of Note, Scale, Chord and Key
https://gopkg.in/music-theory.v0
GNU General Public License v3.0
432 stars 44 forks source link

Support for correct note names for more modes #39

Closed mathaou closed 3 years ago

mathaou commented 3 years ago

Hello! Wonderful library, so far I'm quite happy with whats offered, but there is one thing that bothers me and I'm working on my own fix for right now but I was wondering if you'd thought of it.

Music theory talks about A-G should be used once each for a scale, here you have Gb and G and Db and D.

Here's what the library says about Gb phrygian when using Scale.Of() - root: Gb tones: 1: Gb 2: G 3: A 4: B 5: Db 6: D 7: E

Should be

charneykaye commented 3 years ago

That's great work, thanks, I'll keep a look out for a PR here.

On Sun, Aug 9, 2020, 12:39 Matt Farstad notifications@github.com wrote:

Hello! Wonderful library, so far I'm quite happy with whats offered, but there is one thing that bothers me and I'm working on my own fix for right now but I was wondering if you'd thought of it.

Music theory talks about A-G should be used once each for a scale, here you have Gb and G and Db and D.

Here's what the library says about Gb phrygian when using Scale.Of() - root: Gb tones: 1: Gb 2: G 3: A 4: B 5: Db 6: D 7: E

Should be

https://camo.githubusercontent.com/eec87cfa5d533a198d6fa4174a9e24f1cd919ff9/68747470733a2f2f7777772e62617369636d757369637468656f72792e636f6d2f696d672f672d666c61742d706872796769616e2d6d6f64652d6f6e2d747265626c652d636c65662e706e67

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/go-music-theory/music-theory/issues/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBP5BCDP7PRC75JDRZKNR3R733NXANCNFSM4PZK2SJQ .

mathaou commented 3 years ago

I've decided it's not worth it. That "proper" naming does nothing in terms of functionality and is purely cosmetic at the end of the day. I'm using this library for an app and was going to have a "theoretical naming" option, but decided to work on other more pressing matters.