search

go-mysql-org / go-mysql

a powerful mysql toolset with Go
MIT License
4.52k stars 967 forks source link

fix: (*RowsEvent).handleUnsigned() panic #856

Closed equnchen closed 3 months ago

equnchen commented 3 months ago

canal_panic

lance6716 commented 3 months ago

Hi, can you add an unit test for it?

equnchen commented 3 months ago

Hi, can you add an unit test for it?

Sorry, I'm very busy at work recently. How about we fix this obvious bug first?

lance6716 commented 3 months ago

we have other fix PR like https://github.com/go-mysql-org/go-mysql/pull/495 https://github.com/go-mysql-org/go-mysql/pull/689 https://github.com/go-mysql-org/go-mysql/pull/792 . In order to be fair to them I also request the unit test for this PR

equnchen commented 3 months ago

Hi, can you add an unit test for it?

done