go-mysql-org / go-mysql

a powerful mysql toolset with Go
MIT License
4.58k stars 976 forks source link

Setting collations need adjustment #864

Closed dveeden closed 5 months ago

dveeden commented 5 months ago

Follow-up for #860

See also:

What is needed is that we set the collation in the handshake as 1 byte if the collation <=255 and that we send a SET NAMES ... COLLATE ... if the collation >255.

cc @lance6716 @dvilaverde

dvilaverde commented 5 months ago

I hope https://github.com/go-mysql-org/go-mysql/pull/865 addresses this issue.

dveeden commented 5 months ago

Thanks @dvilaverde !