search

go-mysql-org / go-mysql

a powerful mysql toolset with Go
MIT License
4.6k stars 985 forks source link

CI: Add revive #937

Open dveeden opened 1 week ago

dveeden commented 1 week ago

Using revive as linter might be good. However this would need a reasonable config and probably fixing of some issues like missing comments on exported functions.

@lance6716 @atercattus what do you think?

lance6716 commented 1 week ago

Do you mean turn on revive in current CI framework

https://github.com/go-mysql-org/go-mysql/blob/5acb5690fa62d58bdfd470336ec7df7c88990dee/.github/workflows/ci.yml#L84-L93

https://golangci-lint.run/usage/linters/#revive

LGTM then.