search

go-nlopt / nlopt

A NLopt implementation for Go
MIT License
10 stars 4 forks source link

Proposal: vendor in nlopt #6

Open edaniels opened 1 year ago

edaniels commented 1 year ago

In order to make this library easier to use from most places, I'm wondering if statically linking nlopt is better. wasmer for go does this https://github.com/wasmerio/wasmer-go/blob/master/wasmer/cgo.go. It also allows doing this in a custom way https://github.com/wasmerio/wasmer-go/blob/master/wasmer/cgo_with_custom_wasmer_runtime.go. We could do something similar with the default being static and then dynamic being chosen.

I could put a PR for this but I wanted to get input first since it's a larger change with consequences.

mbogus commented 1 year ago

The suggestion seem very sound, happy to support the PR