search

go-nv / goenv

:blue_car: Like pyenv and rbenv, but for Go.
https://github.com/go-nv/goenv
MIT License
2.05k stars 245 forks source link

GO_BUILD_MIRROR_URL is not working #363

Closed tkyggit closed 6 months ago

tkyggit commented 6 months ago
  1. mirror url is not expected checksum

https://github.com/go-nv/goenv/blob/40b645ae1b317a4395efa1a05dcc66b496c30ce2/plugins/go-build/bin/go-build#L512

maybe expected below

    local tarball_filename=$(basename $package_url)
    mirror_url="${GO_BUILD_MIRROR_URL}/$tarball_filename"

  1. Is the variable IS_TEST in the http function under the wrong condition?

    https://github.com/go-nv/goenv/blob/40b645ae1b317a4395efa1a05dcc66b496c30ce2/plugins/go-build/bin/go-build#L454

    The URL of the mirror is passed in the url, but it is overwritten.

ChronosMasterOfAllTime commented 6 months ago

For which file is the checksum failing?

ChronosMasterOfAllTime commented 6 months ago

Fixed in v2.1.13